Fix Revival Blessing #5471
Closed
Fix Revival Blessing #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, this reminds me that I should separate Revival Blessing support for tests from #5253, as it currently can't be tested. |
Fine with me! |
|
Here we go: ghoulslash#24 |
Oh, right. |
|
Please retarget to master so I can PR you again |
|
Superseded by #5490 |
|
Looks good but the animation is broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival Blessing to fill a battler slot was not updating the absent flags or battler data so they could not be targeted properly:
This PR fixes it:
This should probably have a test, but I'm not very practiced with tests involving switching so would appreciate some assistance there.
Oops it should target master